chore: Tidy up SocialRent
#32
Conversation
DafyddLlyr
commented
Aug 2, 2024
DafyddLlyr
commented
- Sets up required variables for class (no more optional properties)
- Tidies up logic a little, aiming not to make any real changes to this though
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
DafyddLlyr
force-pushed
the
dp/social-rent
branch
from
b943554 to
d0f6086
Compare
|
Sorry I am a bit confused.. maybe we can chat at the dev call later. I sweared a created a PR for social rent during the week with fixing some of the constants, who got approved by @zz-hh-aa and then I merged it. Now it disappeared |
| socialRentCapValues: number[] = [ | ||
| private calculateSocialRent({ numberOfBedrooms, landToTotalRatio }: Property) { | ||
| // TODO: Could this be better expressed as an object? | ||
| const beds = [0, 1, 2, 3, 4, 5, 6]; |
There was a problem hiding this comment.
For example I swear I brought this item out as an object and put it into constants.ts. Since the bed weights are used elsewhere I figured we could have re-use it. Mystery to me
|
found it, I had a branch called gg/social-rent-tidy-up, but I can't tell where it was merged |
|
@gabrielegranello Yep you're right - the PR is #28 Not sure what's going on here, looking into it! I think me rebasing the branch it got merged to is the issue - will try to sort this now 👍 |
|
Closed in favour of #36 |
